[fix][io] Close the kafka source connector got stuck #20698
Merged
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
codelipenghui,
nlu90,
RobertIndie,
Demogorgon314 and
mattisonchao
| @@ -64,6 +66,7 @@ public abstract class KafkaAbstractSource<V> extends PushSource<V> { | |||
| private volatile boolean running = false; | |||
| private KafkaSourceConfig kafkaSourceConfig; | |||
| private Thread runnerThread; | |||
| private final Executor executor = Executors.newSingleThreadExecutor(); | |||
There was a problem hiding this comment.
It's better to set a thread name for debugging purpose.
There was a problem hiding this comment.
And when the executor will be closed?
There was a problem hiding this comment.
It's better to set a thread name for debugging purpose.
fixed
And when the executor will be closed?
changed it to a static variable
There was a problem hiding this comment.
already remove the executor, and just new one thread if needed
RobertIndie
approved these changes
Jun 30, 2023
poorbarcode
changed the title
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java
Outdated
Show resolved
Hide resolved
|
We only use this thread once. Maybe we can new a thread and then run the close task? |
codelipenghui
approved these changes
Jun 30, 2023
Demogorgon314
approved these changes
Jun 30, 2023
mattisonchao
approved these changes
Jun 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #20698 +/- ##
============================================
+ Coverage 72.60% 73.17% +0.56%
- Complexity 32018 32105 +87
============================================
Files 1855 1871 +16
Lines 138569 138964 +395
Branches 15250 15283 +33
============================================
+ Hits 100605 101682 +1077
+ Misses 29945 29239 -706
- Partials 8019 8043 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The failed OWASP dependency check will be fixed by #20699 |
poorbarcode
added a commit
that referenced
this pull request
Jun 30, 2023
Motivation: #19880 (comment) When Kafka connector is closing, it waits for the `runnerThread` to stop, but the task-close is running at the same thread, so it will be stuck. Modifications: run `close` in another thread. (cherry picked from commit c5237ea)
poorbarcode
added a commit
that referenced
this pull request
Jun 30, 2023
Motivation: #19880 (comment) When Kafka connector is closing, it waits for the `runnerThread` to stop, but the task-close is running at the same thread, so it will be stuck. Modifications: run `close` in another thread. (cherry picked from commit c5237ea)
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
Motivation: #19880 (comment) When Kafka connector is closing, it waits for the `runnerThread` to stop, but the task-close is running at the same thread, so it will be stuck. Modifications: run `close` in another thread.
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Jul 12, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
Motivation: apache#19880 (comment) When Kafka connector is closing, it waits for the `runnerThread` to stop, but the task-close is running at the same thread, so it will be stuck. Modifications: run `close` in another thread. (cherry picked from commit c5237ea) (cherry picked from commit 3a2e593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#19880 (comment) When Kafka connector is closing, it waits for the
runnerThreadto stop, but the task-close is running at the same thread, so it will be stuck.Modifications
run
closein another thread.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x